-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(css): style outline #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause accessibility problems.
The default outline style doesn't "look good" but is essential for web accessibility (and lighthouse scores).
Prefer change the outline styles to make it looks good rather than remove it.
b3e5a8a
to
ca18c6e
Compare
--primary-color
as outline color for buttons
ca18c6e
to
e49b69f
Compare
--primary-color
as outline color for buttonsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want change <a>
outline style too
9ac5454
to
e6aee52
Compare
e6aee52
to
8974bac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- should place these in 'base' section, not homepage
- use
:fouces-visible
instead, see :focus vs :focus-visible - change width to 1.5px as the theme use 1.5px for header bottom line and link bottom line
8974bac
to
aa3fda0
Compare
aa3fda0
to
77ec7b1
Compare
Before
After